[Webkit-unassigned] [Bug 30485] Web Inspector: Properties on Arrays and NodeLists are not logged correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 18 19:05:41 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30485





--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2009-10-18 19:05:40 PDT ---
(In reply to comment #6)
> (From update of attachment 41389 [details])
> 
> > +console-format.html:15["test", "test2", undefined, undefined, "test4"]
> 
> It would be nice to have a space or ": " seperator here. Like the CONSOLE
> MESSAGE version.
>

I'll need to add some universal dump code for console messages in another
change.

> 
> > -function dumpMessages()
> > +window.dumpMessages = function(testController)
> 
> These are equivlant. If it is a global function, I prefer the old version.

Done.

> 
> 
> > +        for (var i = 0; i < messages.length; ++i)
> 
> Why < here? I think < would work fine.
> 

Done.

> 
> > +            result.push(messages[i].toMessageElement().textContent);
> 
> Does this need .replace(/\u200b/g, "")?

No, since it does render any expandable nodes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list