[Webkit-unassigned] [Bug 30002] [GStreamer] MediaPlayerPrivate::cancelLoad() can be implemented by setting state to NULL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30002


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41160|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2009-10-15 07:15:12 PDT ---
(From update of attachment 41160)
>  void MediaPlayerPrivate::cancelLoad()
>  {
> -    notImplemented();
> +    if (m_networkState < MediaPlayer::Loading || m_networkState == MediaPlayer::Loaded)
> +        return;
> +
> +    if (m_playBin)
> +        gst_element_set_state(m_playBin, GST_STATE_NULL);
>  }

According to further investigation by Philippe, updateStates is always called
on element state transitions, so it is being done here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.