[Webkit-unassigned] [Bug 30002] [GStreamer] MediaPlayerPrivate::cancelLoad() can be implemented by setting state to NULL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 15 06:42:19 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30002





--- Comment #3 from Philippe Normand <pnormand at igalia.com>  2009-10-15 06:42:19 PDT ---
(In reply to comment #2)
> (From update of attachment 41160 [details])
> >  void MediaPlayerPrivate::cancelLoad()
> >  {
> > -    notImplemented();
> > +    if (m_networkState < MediaPlayer::Loading || m_networkState == MediaPlayer::Loaded)
> > +        return;
> > +
> > +    if (m_playBin)
> > +        gst_element_set_state(m_playBin, GST_STATE_NULL);
> >  }
> 
> Both Mac and Win call updateStates() here after doing their media library
> magics; do you know if there is a reason why we don't need it?

Hmm right. updateStates() is called when we receive the STATE_CHANGE message
but we don't handle STATE_NULL there. Will send a new patch, thanks for
spotting that ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list