[Webkit-unassigned] [Bug 30268] [Qt] Layouttest fast/css/opacity-float.html failed on Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30268





--- Comment #3 from Chang Shu <Chang.Shu at nokia.com>  2009-10-13 06:38:10 PDT ---
(In reply to comment #2)
> (From update of attachment 41041 [details])
> I think your patch looks good, but I think qt/DumpRenderTree.cpp's
> resetToConsistentStateBeforeTesting() should also set the default locale back
> (i.e. using QLocale::setDefault).
> 
> Could you add that line, just so that we are safe that after a test called
> setPOSIXLocale we set this back and avoid side-effects in other tests?

Thanks for the comments! I was asking the same question to Evan in bug 29653
and now I forgot to do it myself. :(

Btw, I see there is already a line of "setlocale(LC_ALL,"");" in function
resetToConsistentStateBeforeTesting(). However, I don't think it works for Qt.
Shall I remove it and replace with the following line?
    QLocale qlocale;
    QLocale::setDefault(qlocale);

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.