[Webkit-unassigned] [Bug 30268] [Qt] Layouttest fast/css/opacity-float.html failed on Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30268


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41041|review?                     |review-
               Flag|                            |




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2009-10-12 22:46:08 PDT ---
(From update of attachment 41041)
I think your patch looks good, but I think qt/DumpRenderTree.cpp's
resetToConsistentStateBeforeTesting() should also set the default locale back
(i.e. using QLocale::setDefault).

Could you add that line, just so that we are safe that after a test called
setPOSIXLocale we set this back and avoid side-effects in other tests?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.