[Webkit-unassigned] [Bug 30213] [Qt] Avoid ErrorPageExtensionOption to hold empty 'url' field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30213





--- Comment #3 from Antonio Gomes (tonikitoo) <tonikitoo at webkit.org>  2009-10-11 21:17:07 PDT ---
thx for your comments, simon.

> Instead of converting the url to a QString first before checking if it's null,
> can you call isEmpty() on QUrl instead?

sure thing.

> I.e.
> 
> QUrl url = m_reply->url();
> if (url.isEmpty())
>     url = m_request.url();

ok

> Is there any way to write a unit test for this? :)

i will try to get a auto test for it, before a next iteration here ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.