[Webkit-unassigned] [Bug 30213] [Qt] Avoid ErrorPageExtensionOption to hold empty 'url' field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30213


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40875|review?                     |review-
               Flag|                            |




--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2009-10-09 07:36:54 PDT ---
(From update of attachment 40875)

> -        QUrl url = m_reply->url();
> +        QUrl url = (m_reply->url().toString().isNull()) ? m_request.url(): m_reply->url();

Instead of converting the url to a QString first before checking if it's null,
can you call isEmpty() on QUrl instead?

I.e.

QUrl url = m_reply->url();
if (url.isEmpty())
    url = m_request.url();


Is there any way to write a unit test for this? :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.