[Webkit-unassigned] [Bug 29653] [Qt] Qt-based browser fails to show the right language translation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29653





--- Comment #26 from Chang Shu <Chang.Shu at nokia.com>  2009-10-08 12:53:19 PDT ---
Thanks for the comments, Evan. That makes a lot sense.
The current code does not pass LC_ALL,etc., to the executable at all. They are
just Null. If this is preferred, we will keep the way it is. If we want a
default value, such as en-US, I think we should set it in run-webkit-tests.
Then, if any test case wants to test particular locale, use setPosixLocale in
the test case. (btw, would this affect the subsequent test cases?)
But I would equally take the way that each test case sets itslocale if it
depends on it. My next patch will be based on the last approach.

(In reply to comment #25)
> The locale-setting API change has landed.  We now always call setlocale(LC_ALL,
> "") which means tests are run in whichever env you specify.
> 
> Currently WebKit tests rely on the locale being English (or at least LC_NUMERIC
> not putting in commas); for example, DumpRenderTree calls snprintf directly
> rather than going through String::format() which is locale-independent for at
> least Qt.
> 
> I think it'd be ok to always force an English locale when running the tests;
> however, WebKit needs to work from any locale!  There are a bunch of WebKit
> bugs that forcing the locale would hide -- like what I'm working on in bug
> 18994 -- and until those are fixed it would be valuable to still be able to run
> the tests in any locale.  (As I find such bugs I intend to add tests like I've
> added in bug 18994 that explicitly manage the locale so they will continue to
> test the code regardless of the locale run-webkit-tests is ran in.)
> 
> Maybe a better idea is to just check LC_ALL and related variables (maybe just
> parse the output of the 'locale' command?) when running run-webkit-tests and
> warn the person running the tests accordingly that they should set their locale
> if they want run-webkit-tests to pass.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.