[Webkit-unassigned] [Bug 29653] [Qt] Qt-based browser fails to show the right language translation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29653





--- Comment #25 from Evan Martin <evan at chromium.org>  2009-10-08 12:39:45 PDT ---
The locale-setting API change has landed.  We now always call setlocale(LC_ALL,
"") which means tests are run in whichever env you specify.

Currently WebKit tests rely on the locale being English (or at least LC_NUMERIC
not putting in commas); for example, DumpRenderTree calls snprintf directly
rather than going through String::format() which is locale-independent for at
least Qt.

I think it'd be ok to always force an English locale when running the tests;
however, WebKit needs to work from any locale!  There are a bunch of WebKit
bugs that forcing the locale would hide -- like what I'm working on in bug
18994 -- and until those are fixed it would be valuable to still be able to run
the tests in any locale.  (As I find such bugs I intend to add tests like I've
added in bug 18994 that explicitly manage the locale so they will continue to
test the code regardless of the locale run-webkit-tests is ran in.)

Maybe a better idea is to just check LC_ALL and related variables (maybe just
parse the output of the 'locale' command?) when running run-webkit-tests and
warn the person running the tests accordingly that they should set their locale
if they want run-webkit-tests to pass.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.