[Webkit-unassigned] [Bug 30033] [chromium] DateExtension has reliability bot crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30033





--- Comment #8 from John Abd-El-Malek <jam at chromium.org>  2009-10-05 11:01:18 PDT ---
(In reply to comment #6)
> (From update of attachment 40642 [details])
> We should add a test for the crash.

This wasn't a reproducible crash.  I'm open to suggestions on how this crash
can be reproduced.

> 
> + v8::Local<v8::Value> result =
> V8Proxy::retrieve()->evaluate(WebCore::ScriptSourceCode("Date"), 0);
> 
> This seems overly complicated.  Why not just get the "Date" property of the
> context's global object?

Mads had suggested this.  It's useful in case the page replaced the Date
object, in which case we don't want to override getTime since they could have
changed its functionality (i.e. added extra parameters).

> 
> Other than those two issue, this looks reasonable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.