[Webkit-unassigned] [Bug 30033] [chromium] DateExtension has reliability bot crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30033





--- Comment #9 from Adam Barth <abarth at webkit.org>  2009-10-05 13:10:30 PDT ---
(In reply to comment #8)
> This wasn't a reproducible crash.  I'm open to suggestions on how this crash
> can be reproduced.

Did you try running GC explicitly at an opportune moment?  I think there's a
function to force GC around somewhere in LayoutTests.

> > + v8::Local<v8::Value> result =
> > V8Proxy::retrieve()->evaluate(WebCore::ScriptSourceCode("Date"), 0);
> > 
> > This seems overly complicated.  Why not just get the "Date" property of the
> > context's global object?
> 
> Mads had suggested this.  It's useful in case the page replaced the Date
> object, in which case we don't want to override getTime since they could have
> changed its functionality (i.e. added extra parameters).

How does this solve that problem?  Won't evaling "Date" just give you the
modified object?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.