[Webkit-unassigned] [Bug 30021] check-webkit-style does not detect missing spaces around &=, |=, -=, and +=

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30021


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #4 from Darin Adler <darin at apple.com>  2009-10-02 15:00:08 PDT ---
(In reply to comment #3)
> I noticed that check-webkit-style is intentionally coded to allow
> constructs such as a = 3<<4;

That sounds wrong. WebKit coding style would require spaces there.

> Also, another exception is if
> ((a=b) != c) construction where a comment in the check-webkit-style file says
> that there must NOT be spaces around = inside if.

That's wrong. My guess is that it came from someone else's coding style
guidelines. Maybe Google internal guidelines?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.