[Webkit-unassigned] [Bug 30021] check-webkit-style does not detect missing spaces around &=, |=, -=, and +=

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 2 15:06:18 PDT 2009


--- Comment #5 from Carol Szabo <carol.szabo at nokia.com>  2009-10-02 15:06:18 PDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > I noticed that check-webkit-style is intentionally coded to allow
> > constructs such as a = 3<<4;
> That sounds wrong. WebKit coding style would require spaces there.
> > Also, another exception is if
> > ((a=b) != c) construction where a comment in the check-webkit-style file says
> > that there must NOT be spaces around = inside if.
> That's wrong. My guess is that it came from someone else's coding style
> guidelines. Maybe Google internal guidelines?

Thanks for the clarification. If I'll edit the check-webkit-style file again I
shall fix those, but till then I'd like my current fixes landed so that I do
not have to manually add them to my new workspaces.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list