[Webkit-unassigned] [Bug 29970] [Qt] Missing layoutTestController.overridePreference() implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29970


Jakub Wieczorek <faw217 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40523|                            |review?
               Flag|                            |
  Attachment #40459|0                           |1
        is obsolete|                            |




--- Comment #5 from Jakub Wieczorek <faw217 at gmail.com>  2009-10-02 08:57:03 PDT ---
Created an attachment (id=40523)
 --> (https://bugs.webkit.org/attachment.cgi?id=40523)
Implement the missing function

(In reply to comment #4)
> (From update of attachment 40459 [details])
> Great stuff, but I suggest to simplify the implmeneitation:
> 
> Store the defaults in QWebSettings::globalSettings(), make overridePreferece()
> set the settings on the page's settings object and make resetSEttings() use
> resetAttribute, resetFontSize(), etc. to trigger the fallback to the global
> settings.

Sounds good, done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.