[Webkit-unassigned] [Bug 29970] [Qt] Missing layoutTestController.overridePreference() implementation

Fri Oct 2 08:04:32 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=29970

Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40459|review?                     |review-
               Flag|                            |

--- Comment #4 from Simon Hausmann <hausmann at webkit.org>  2009-10-02 08:04:32 PDT ---
(From update of attachment 40459)
Great stuff, but I suggest to simplify the implmeneitation:

Store the defaults in QWebSettings::globalSettings(), make overridePreferece()
set the settings on the page's settings object and make resetSEttings() use
resetAttribute, resetFontSize(), etc. to trigger the fallback to the global
settings.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.