[Webkit-unassigned] [Bug 31806] Make GIF decoder support down-sampling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31806





--- Comment #7 from Peter Kasting <pkasting at google.com>  2009-11-30 13:58:27 PST ---
(In reply to comment #6)
> The code is here:
> 
> #if ENABLE(IMAGE_DECODER_DOWN_SAMPLING)
>     if (m_scaled) {
>         int left = upperBoundScaledX(frameRect.x());
>         int right = lowerBoundScaledX(frameRect.right(), left);
>         int top = upperBoundScaledY(frameRect.y());
>         int bottom = lowerBoundScaledY(frameRect.bottom(), top);
>         buffer->setScaledRect(IntRect(left, top, right - left, bottom - top));
>     } else {
>         buffer->setScaledRect(frameRect);
>     }
> #endif
> 
> I can remove the braces but I really think leaving them there in this case is
> better.

Personally, I agree with you.  However, the WebKit style guide is explicit
about this case, and says that there are to be no braces on the second arm.  We
shouldn't violate the style guide simply because we don't like some of its
rules, or there is no point to having a style guide.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.