[Webkit-unassigned] [Bug 31806] Make GIF decoder support down-sampling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31806





--- Comment #6 from Yong Li <yong.li.webkit at gmail.com>  2009-11-30 13:56:22 PST ---
(In reply to comment #5)
> Attachment 43716 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> Done processing WebCore/platform/image-decoders/ImageDecoder.cpp
> WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp:286:  One line control
> clauses should not use braces.  [whitespace/braces] [4]
> Done processing WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp
> Done processing WebCore/platform/image-decoders/ImageDecoder.h
> Total errors found: 1

Hi, Adam,

The code is here:

#if ENABLE(IMAGE_DECODER_DOWN_SAMPLING)
    if (m_scaled) {
        int left = upperBoundScaledX(frameRect.x());
        int right = lowerBoundScaledX(frameRect.right(), left);
        int top = upperBoundScaledY(frameRect.y());
        int bottom = lowerBoundScaledY(frameRect.bottom(), top);
        buffer->setScaledRect(IntRect(left, top, right - left, bottom - top));
    } else {
        buffer->setScaledRect(frameRect);
    }
#endif

I can remove the braces but I really think leaving them there in this case is
better.

-Yong

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.