[Webkit-unassigned] [Bug 31953] [Qt] [code cleaning] Clean the code paths of QWebFrame::render()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 29 07:43:20 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31953


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43983|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2009-11-29 07:43:20 PST ---
(From update of attachment 43983)
I'm not sure this is really any more clear.  Especially it seems kinda strange
to turn the if into an ASSERT in renderPrivate.

I'd be OK with this if you were just cleaning up render(4 args) as you have,
but it seems strange to change renderPrivate and rendner(QPainter*) too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list