[Webkit-unassigned] [Bug 31799] run-webkit-tests doesn't accept directories/files with --skipped=only parameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31799





--- Comment #5 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-11-25 12:59:59 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> 
> Thanks for your reflections and advices. The modified patch is submitted.
> Sorry for coding style violations. I will regard lots better next time.

Some of it is personal preference, too.  I'm not sure all of this is codified
in our style documentation (since that mostly reflects C++ code).

> > >                          if (!&fileShouldBeIgnored($skipped)) {
> > 
> > Bonus points for removing the unneeded '&' in the 'if' statement above.  Not
> > necessary though.
> 
> I didn't find unneeded if. Which do you mean?

I meant changing this:

-                         if (!&fileShouldBeIgnored($skipped)) {
+                         if (!fileShouldBeIgnored($skipped)) {

The '&' operator is unnecessary in this case (and is a remnant of an earlier
Perl style).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.