[Webkit-unassigned] [Bug 31799] run-webkit-tests doesn't accept directories/files with --skipped=only parameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31799





--- Comment #4 from Csaba Osztrogonac <ossy at webkit.org>  2009-11-25 12:52:41 PST ---
(In reply to comment #3)

Thanks for your reflections and advices. The modified patch is submitted.
Sorry for coding style violations. I will regard lots better next time.

> >      foreach my $level (@platformTestHierarchy) {
> >          if (open SKIPPED, "<", "$level/Skipped") {
> >              if ($verbose) {
> > @@ -2106,7 +2116,13 @@ sub readSkippedFiles
> >                  if ($skipped && $skipped !~ /^#/) {
> >                      if ($skippedOnly) {
> >                          if (!&fileShouldBeIgnored($skipped)) {
> 
> Bonus points for removing the unneeded '&' in the 'if' statement above.  Not
> necessary though.
I didn't find unneeded if. Which do you mean?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.