[Webkit-unassigned] [Bug 30997] [Gtk] Implement AtkDocument's attribute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30997


Joanmarie Diggs <joanmarie.diggs at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42317|0                           |1
        is obsolete|                            |
  Attachment #43069|                            |review?
               Flag|                            |




--- Comment #17 from Joanmarie Diggs <joanmarie.diggs at gmail.com>  2009-11-12 09:35:20 PST ---
Created an attachment (id=43069)
 --> (https://bugs.webkit.org/attachment.cgi?id=43069)
Layout Test - Take 3

Thanks for the review! Hopefully third time will be charm. :-)

> The layout tests changes are missing a Changelog.

Added.

> > +    AtkDocument* axDocument = ATK_DOCUMENT(m_element);
> > +    return JSStringCreateWithUTF8CString(atk_document_get_attribute_value(axDocument, "Encoding"));
> 
> No need for axDocument here. I think you can just pass it to
> atk_document_get_attribute_value directly.

Done.

> > +    AtkDocument* axDocument = ATK_DOCUMENT(m_element);
> > +    return JSStringCreateWithUTF8CString(atk_document_get_attribute_value(axDocument, "URI"));
> 
> Ditto.

Ditto. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.