[Webkit-unassigned] [Bug 30997] [Gtk] Implement AtkDocument's attribute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30997


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42317|review?                     |review-
               Flag|                            |




--- Comment #16 from Jan Alonzo <jmalonzo at gmail.com>  2009-11-12 01:53:09 PST ---
(From update of attachment 42317)
>  LayoutTests/platform/mac/Skipped                   |    3 +++
>  LayoutTests/platform/win/Skipped                   |    1 +
>  WebKitTools/ChangeLog                              |   20 ++++++++++++++++++++
>  .../DumpRenderTree/AccessibilityUIElement.cpp      |   14 ++++++++++++++
>  .../DumpRenderTree/AccessibilityUIElement.h        |    2 ++
>  .../gtk/AccessibilityUIElementGtk.cpp              |   20 ++++++++++++++++++++
>  .../mac/AccessibilityUIElementMac.mm               |   10 ++++++++++
>  .../win/AccessibilityUIElementWin.cpp              |   11 +++++++++++
>  8 files changed, 81 insertions(+), 0 deletions(-)

The layout tests changes are missing a Changelog.

> +
> +    AtkDocument* axDocument = ATK_DOCUMENT(m_element);
> +    return JSStringCreateWithUTF8CString(atk_document_get_attribute_value(axDocument, "Encoding"));

No need for axDocument here. I think you can just pass it to
atk_document_get_attribute_value directly.

> +}
> +
> +JSStringRef AccessibilityUIElement::documentURI()
> +{
> +    AtkRole role = atk_object_get_role(ATK_OBJECT(m_element));
> +    if (role != ATK_ROLE_DOCUMENT_FRAME)
> +        return JSStringCreateWithCharacters(0, 0);
> +
> +    AtkDocument* axDocument = ATK_DOCUMENT(m_element);
> +    return JSStringCreateWithUTF8CString(atk_document_get_attribute_value(axDocument, "URI"));

Ditto.

Patch looks good. But I'm going to say r- because of the missing Changelog for
the layout test changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.