[Webkit-unassigned] [Bug 18831] [GTK] support windowless plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18831





--- Comment #31 from Girish Ramakrishnan <girish at forwardbias.in>  2009-11-10 06:32:27 PDT ---
(In reply to comment #28)
> >>  #include <gdk/gdkx.h>
> >> +#define Bool int
> >> +#define Status int
> >> +#include <X11/extensions/Xrender.h>
> 
> > What are these for?
> 
> See getVisualAndColormap().  It's mostly copied from the Qt backend.  When a
> 32-bit visual is requested, we use XRender to find the most appropriate visual
> (that is, a visual with an alpha channel).  I'm not sure what the deal is with
> the defines: apparently *somewhere* a lot of the defines in the Xlib headers
> get undefined, including Bool and Status. 

Qt undefines them since they conflict with Qt has a type named Status and event
enums named FocusIn, FocusOut and all. Also, iirc, JSC also has a Status enum.

> 
> >> +    exposeEvent.width = exposedRect.x() + exposedRect.width(); // flash bug? it thinks width is the right in transparent mode
> >> +    exposeEvent.height = exposedRect.y() + exposedRect.height(); // flash bug? it thinks height is the bottom in transparent mode
> >
> > I don't understand these comments. You mean it thinks height is the absolute y
> > position? Will this break other plugins?
> 

That's right. Flash thinks that height parameter is the bottom and width
parameter is the right. As Brian said, this can cause no harm to other plugin
except that we end up painting a little more than necessary.

> 
> >> +    // On Unix, only call plugin if it's full-page or windowed
> >> +    if (m_mode != NP_FULL && m_mode != NP_EMBED)
> >> +        return;
> >
> > What does 'call plugin' mean? Calling setNPWindow?
> 
> I don't know; copied from the Qt backend.
> 

We should change this to "call plugin's setwindow"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.