[Webkit-unassigned] [Bug 11031] Another crazy counters bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=11031





--- Comment #10 from Carol Szabo <carol.szabo at nokia.com>  2009-11-06 08:30:30 PDT ---
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (From update of attachment 42617 [details] [details] [details])
> > > > -    virtual bool isEmpty() const { return firstChild() == 0; }
> > > > +    virtual bool isEmpty() const { return firstChild(); }
> > > 
> > > This doesn’t seem right.
> > 
> > If the reviewer thinks that this is wrong (which I agree with), I'll change it,
> > but WebKit Style Guidelines require that there are no explicit comparisons to
> > 0.
> 
> The above change reverses the logic.

Ooops. Sorry, my mistake, I'll fix it and submit a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.