[Webkit-unassigned] [Bug 11031] Another crazy counters bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 6 08:27:24 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=11031





--- Comment #9 from mitz at webkit.org  2009-11-06 08:27:23 PDT ---
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 42617 [details] [details])
> > > -    virtual bool isEmpty() const { return firstChild() == 0; }
> > > +    virtual bool isEmpty() const { return firstChild(); }
> > 
> > This doesn’t seem right.
> 
> If the reviewer thinks that this is wrong (which I agree with), I'll change it,
> but WebKit Style Guidelines require that there are no explicit comparisons to
> 0.

The above change reverses the logic.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list