[Webkit-unassigned] [Bug 29972] Implement URL decomposition IDL attributes for HTMLAnchorElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29972





--- Comment #26 from Timothy Hatcher <timothy at hatcher.name>  2009-11-05 11:07:19 PDT ---
(In reply to comment #25)
> (In reply to comment #24)
> > The first build runs CodeGeneratorObjC.pm to generate the ObjC bindings, and
> > then checks if public interfaces changed (PublicDOMInterfaces.h). Since the API
> > of DOMHTMLAnchorElement changed, the script simply dies. (CodeGeneratorObjC.pm
> > line 297).
> 
> Right, that means that this change can break Mac OS X applications who depend
> on the current interface. I think, however, that changing read-only properties
> to be read-write is actually an acceptable change. We’ll need to talk to Tim
> Hatcher about how to resolve this. For the short term, one possibility is to
> put #if in the IDL file that makes the attributes be read-only in Objective-C
> for now, and read-write only in all other languages.

Those are really the only two options (make it public or #ifdef it to be
readonly), since ObjC properties can't be split between public and private
headers like two getter and setter methods can.

> > The second time, the ObjC bindigns are already generated, so there is no check
> > of SDK API, and the build succeeds. 
> 
> The fact that the build succeeds a second time is a bug in the build system. If
> a patch violates the rules about changing public DOM interfaces that should be
> a permanent build failure, not one we can work around by rebuilding.

That is a bug, we need to remove the generated file so it gets rebuilt each
time until the public change is resolved. Filed as bug 31178.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.