[Webkit-unassigned] [Bug 29972] Implement URL decomposition IDL attributes for HTMLAnchorElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29972


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |timothy at hatcher.name




--- Comment #25 from Darin Adler <darin at apple.com>  2009-11-05 10:21:14 PDT ---
(In reply to comment #24)
> The first build runs CodeGeneratorObjC.pm to generate the ObjC bindings, and
> then checks if public interfaces changed (PublicDOMInterfaces.h). Since the API
> of DOMHTMLAnchorElement changed, the script simply dies. (CodeGeneratorObjC.pm
> line 297).

Right, that means that this change can break Mac OS X applications who depend
on the current interface. I think, however, that changing read-only properties
to be read-write is actually an acceptable change. We’ll need to talk to Tim
Hatcher about how to resolve this. For the short term, one possibility is to
put #if in the IDL file that makes the attributes be read-only in Objective-C
for now, and read-write only in all other languages.

> The second time, the ObjC bindigns are already generated, so there is no check
> of SDK API, and the build succeeds. 

The fact that the build succeeds a second time is a bug in the build system. If
a patch violates the rules about changing public DOM interfaces that should be
a permanent build failure, not one we can work around by rebuilding.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.