[Webkit-unassigned] [Bug 30997] [Gtk] Implement AtkDocument's attribute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30997





--- Comment #5 from Joanmarie Diggs <joanmarie.diggs at gmail.com>  2009-11-02 04:45:26 PDT ---
(In reply to comment #2)
> (From update of attachment 42280 [details])
> > +    String value = String();
> > +    if (!g_ascii_strcasecmp(attribute, "DocType") && coreDocument->doctype())
> > +        value = coreDocument->doctype()->name();
> > +    else if (!g_ascii_strcasecmp(attribute, "Encoding"))
> > +        value = coreDocument->charset();
> > +    else if (!g_ascii_strcasecmp(attribute, "URI"))
> > +        value = coreDocument->documentURI();
> > +    if (!value.isEmpty())
> > +        return returnString(value);
> 
> Should this return an empty string if it's an empty value?

Personally, I don't think so. If an empty string is returned, it will wind up
being added to the AttributeSet for the document (unless, of course, I prevent
that from occurring in webkit_accessible_document_get_attributes).

While there is no official rule (that I've found) that states that one should
not have an AtkAttribute with no value in an AtkAttributeSet, I've never seen a
AtkAttribute without a value in an AtkAttributeSet.

Is there a reason why it should return an empty string rather than NULL which
I'm failing to take into account?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.