[Webkit-unassigned] [Bug 30997] [Gtk] Implement AtkDocument's attribute support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30997





--- Comment #4 from Joanmarie Diggs <joanmarie.diggs at gmail.com>  2009-11-02 04:14:59 PDT ---
(In reply to comment #3)

> Is the result platform-specific? 

In the sense that Gtk is currently the only platform that seems to have a need
to implement this, yes. However, the document type, url, and encoding are not
a11y things. Nor would I expect them them to vary based on platform should the
other platforms implement them down the road. So, in my mind, if there is
magical test-skipping/ignoring foo (which there is I see from your later
comment), the result would *not* be platform-specific.

All of that said, I'm a layout test n00b AND a WebKit n00b. :-) So given my
response to the above, what are your thoughts? I'm happy to make it
platform-specific, "just in case."

> Since Mac & Win are stubbed, I think this test will need to be added to Mac &
> Win's Skipped list (see LayoutTests/platform/{mac,win}/Skipped). Ditto with Qt.
> 
> You also missed the impl for Qt :).

I wouldn't say "missed." It's more like "drew a conclusion and intentionally
failed to provide." :-) I looked in WebKitTools/DumpRenderTree/<platform>. Win,
Mac, and Gtk all have AccessibilityController and AccessibilityUIElement
implementations; Qt does not seem to have these things. My
conclusion/assumption was that if Qt should have stubs for the document
attributes, it would already have stubs (if not actual functions) for all of
the other things being tested.

Should I add new AccessibilityController and AccessibilityUIElement
implementations for Qt?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.