[Webkit-unassigned] [Bug 25494] add PositionConstructors.h in preparation for adding more position constructor functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25494


mjs at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29924|review?                     |review-
               Flag|                            |




------- Comment #7 from mjs at apple.com  2009-05-22 01:35 PDT -------
(From update of attachment 29924)
I don't think calling this header PositionConstructors.h is right.
"Constructor" means a specific thing in C++, and these aren't it, so it's kind
of confusing.

I actually think it's fine for these functions to be in Position.h, since they
are effectively part of the interface to Position, but if you can think of a
good alternate header name, that's ok too.

Also, while I'm nitpicking, I don't think the names of functions that take
nodes necessarily need Node in them.It could just be:

static inline Position positionBefore(const Node* node)
static inline Position positionAfter(const Node* node)
static inline Position firstDeepEditingPosition(Node* anchorNode)
static inline Position lastDeepEditingPosition(Node* anchorNode)

r- for the header name. Function renames are optional.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.