[Webkit-unassigned] [Bug 25467] JavaScript debugger should use function.displayName as the function's name in the call stack

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25467





------- Comment #5 from ggaren at apple.com  2009-05-04 23:03 PDT -------
(From update of attachment 30011)
> +UString DebuggerCallFrame::calculatedFunctionName() const
> +{
> +    if (!m_callFrame->codeBlock())
> +        return 0;
> +    
> +    JSFunction* function = static_cast<JSFunction*>(m_callFrame->callee());
> +    if (!function)
> +        return 0;
> +    return function->calculatedDisplayName(&m_callFrame->globalData());
> +}

The best way to make a null string is "UString()", rather than "0".

> +    UString functionName = m_debuggerCallFrame.calculatedFunctionName();
> +    if (functionName.isEmpty())
>          return String();
> -    return *functionName;
> +    return functionName;
>  }

Just plain "return m_debuggerCallFrame.calculatedFunctionName();" should work.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.