[Webkit-unassigned] [Bug 24949] Back out some of the changes to FrameLoader in r42055 to unbreak Chrome.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24949





------- Comment #5 from fishd at chromium.org  2009-03-30 17:32 PDT -------
> You should be using loadFrameRequestWithFormAndValues for this.

Whoops.  I "misspoke"... we use loadURL when creating a child frame.  I'm sure
it should be easy to replace this usage then.

> > we use closeURL as part of our asynchronous procedure for shutting down a WebView.
> 
> You may want to use detachFromParent() for this.

Hmm, I'm not sure that that will work as is...  unfortunately, we need just the
first part which runs unload handlers.


> All right.

Thank you!


> We need quite a bit of improvement in FrameLoader, so the sooner you
> can get the Chromium loading code checked into the WebKit tree, the better.
> This is just the first step of some major repair. It looks like the Chrome
> requirements are actively getting in the way of fixing the design here!

Yeah, I really don't like holding up progress on improving FrameLoader.  It is
an ugly beast.  I'd be great if we could discuss further the funny requirements
Chromium has on navigation.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.