[Webkit-unassigned] [Bug 24851] Failures in http/tests/xhlhttprequest/web-apps on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24851





------- Comment #9 from bweinstein at gmail.com  2009-03-28 10:24 PDT -------
(In reply to comment #8)
> +        //Get rid of the status number from statusText
> 
> Please add a space after "//", and a period after the sentence. Also, it's
> "status code", not number.
> 
> +        spacePos = statusText.find(" ");
> +        if (spacePos != -1)
> +            statusText = statusText.substring(spacePos + 1);
> 
> You were just copying existing code, but I don't think that the check is useful
> - even if spacePos equals -1, it is safe to use substring, because its argument
> will be 0.
> 
> +        Tests in http/tests/xmlhttprequest/web-apps were taking results from
> platform/mac instead of LayoutTests, so added the values from LayoutTests into
> platform/win, and removed a few tests from the skip list that are fixed by the
> fix to platform/network/cf/ResourceResponseCFNet.cpp                
> 
> Please break this line at some reasonable width! Also, there are tabs at the
> end of it.
> 
> I'm confused by the need to make copies of expected results in platform/win. Do
> we really take expected results from platform/mac when testing on Windows? Is
> this a feature, or a bug?
> 

Does that mean that check is not useful in either instance of the code? Should
I just get rid of it in both places? Because like you said, even if nothing is
found, the start of the substring will just be 0.

Also, it is trying to match platform/mac because, as I was told, they are
trying to get the results to match Leopard/Snow Leopard as closely as possible,
so adding the files to platform/win is needed for the patch to take effect.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.