[Webkit-unassigned] [Bug 24851] Failures in http/tests/xhlhttprequest/web-apps on Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 28 02:26:06 PDT 2009


ap at webkit.org changed:

           What    |Removed                     |Added
                 CC|                            |mrowe at apple.com

------- Comment #8 from ap at webkit.org  2009-03-28 02:26 PDT -------
+        //Get rid of the status number from statusText

Please add a space after "//", and a period after the sentence. Also, it's
"status code", not number.

+        spacePos = statusText.find(" ");
+        if (spacePos != -1)
+            statusText = statusText.substring(spacePos + 1);

You were just copying existing code, but I don't think that the check is useful
- even if spacePos equals -1, it is safe to use substring, because its argument
will be 0.

+        Tests in http/tests/xmlhttprequest/web-apps were taking results from
platform/mac instead of LayoutTests, so added the values from LayoutTests into
platform/win, and removed a few tests from the skip list that are fixed by the
fix to platform/network/cf/ResourceResponseCFNet.cpp                

Please break this line at some reasonable width! Also, there are tabs at the
end of it.

I'm confused by the need to make copies of expected results in platform/win. Do
we really take expected results from platform/mac when testing on Windows? Is
this a feature, or a bug?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list