[Webkit-unassigned] [Bug 23932] Current API does not allow us to open target="_blank" links in new tabs instead of windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23932





------- Comment #15 from xan.lopez at gmail.com  2009-03-25 03:57 PDT -------
(In reply to comment #14)
> >      // FIXME: I think Qt version marshals this to another thread so when we
> >      // have multi-threaded download, we might need to do the same
> > -    (core(m_frame)->loader()->*policyFunction)(PolicyUse);
> > +    if (!isHandled)
> > +        webkit_web_policy_decision_use(m_policyDecision);
> 
> please don't include this hunk in this when landing, IIRC there was another
> patch making these consistent!
> 

The other bug was about

 if (isHandled) webkit_web_policy_decision_ignore(policy);

I think. We are already using the policy if the signal is not handled in the
other cases, and I think that's right.
> 
> 
> > +    WebKitWebNavigationAction* navigationAction = getNavigationAction (action);
> 
> Coding Style, no ' ' between Action and (action) please. The other call to
> getNavigationAction was wrong too.
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.