[Webkit-unassigned] [Bug 23932] Current API does not allow us to open target="_blank" links in new tabs instead of windows
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 25 03:52:12 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=23932
zecke at selfish.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28850|review? |review+
Flag| |
------- Comment #14 from zecke at selfish.org 2009-03-25 03:52 PDT -------
(From update of attachment 28850)
Please use the prepare-ChangeLog script in the future and who ever lands this
patch please fix the coding style.
> +2009-03-23 Alejandro Garcia Castro <alex at igalia.com>
> +
> + Reviewed by .
tabs?
> + * WebCoreSupport/FrameLoaderClientGtk.cpp:
tabs? and maybe even in th enext lines...
> // FIXME: I think Qt version marshals this to another thread so when we
> // have multi-threaded download, we might need to do the same
> - (core(m_frame)->loader()->*policyFunction)(PolicyUse);
> + if (!isHandled)
> + webkit_web_policy_decision_use(m_policyDecision);
please don't include this hunk in this when landing, IIRC there was another
patch making these consistent!
> + WebKitWebNavigationAction* navigationAction = getNavigationAction (action);
Coding Style, no ' ' between Action and (action) please. The other call to
getNavigationAction was wrong too.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list