[Webkit-unassigned] [Bug 24776] Disabling HTML5 Database breaks the build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 24 12:19:24 PDT 2009


------- Comment #5 from darin at apple.com  2009-03-24 12:19 PDT -------
(From update of attachment 28894)
It’s not a good idea to change inlining just to fix compiles like this. The
setHasOpenDatabases and hasOpendatabases functions can remain inlined in the
header, but just be after the class definition and separate.

We compile with unused argument settings, so you’ll need to use the
UNUSED_PARAM macro in the #else cases of these various features.

This does *not* seem like quite the right approach. I’m not sure how much
you’ve done to try other things first. A function like stopDatabases() makes
sense even if you don’t have databases enabled. But a feature like
addOpenDatabase doesn’t. And databaseThread makes even less sense.

I’m not going to set review- because perhaps the others who have been working
with you on earlier versions of this patch have a different view.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list