[Webkit-unassigned] [Bug 24779] Conditionalize CFNetwork-Specific Code in WebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24779


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28893|                            |review+
               Flag|                            |




------- Comment #2 from aroben at apple.com  2009-03-24 11:35 PDT -------
(From update of attachment 28893)
> +++ WebKit/win/WebView.cpp	(working copy)
> @@ -50,7 +50,9 @@
>  #include "WebNotificationCenter.h"
>  #include "WebPreferences.h"
>  #pragma warning( push, 0 )
> +#if PLATFORM(CG)
>  #include <CoreGraphics/CGContext.h>
> +#endif

It would be better to move the conditionally-included headers down below the
unconditionally-included headers. Each #if/#endif pair can form its own
paragraph.

> +#include <CoreFoundation/CoreFoundation.h>

Should this be inside #if PLATFORM(CF)/#endif?

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.