[Webkit-unassigned] [Bug 24779] Conditionalize CFNetwork-Specific Code in WebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24779





------- Comment #3 from bfulgham at webkit.org  2009-03-24 11:40 PDT -------
(In reply to comment #2)
> (From update of attachment 28893 [review])
> > +++ WebKit/win/WebView.cpp	(working copy)
> > @@ -50,7 +50,9 @@
> >  #include "WebNotificationCenter.h"
> >  #include "WebPreferences.h"
> >  #pragma warning( push, 0 )
> > +#if PLATFORM(CG)
> >  #include <CoreGraphics/CGContext.h>
> > +#endif
> 
> It would be better to move the conditionally-included headers down below the
> unconditionally-included headers. Each #if/#endif pair can form its own
> paragraph.

Will do.

> > +#include <CoreFoundation/CoreFoundation.h>
> 
> Should this be inside #if PLATFORM(CF)/#endif?

Currently, all Windows builds use CoreFoundation, so if this was not included
I'm not sure if anything would build.  But it certainly won't hurt to add the
check, and might help some future porter so I'll change it when I commit.

> r=me
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.