[Webkit-unassigned] [Bug 24586] maxDeepOffset is confusing and should be removed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24586





------- Comment #4 from eric at webkit.org  2009-03-16 11:16 PDT -------

> I think that lastOffsetInNode is misleading because the offset returned isn't
> necessarily "in" the node given to the function.  I think it's a good
> description of what maxDeepOffset returns for text nodes and containers, but
> not so good for what it returns for tables, images, br, etc.  I think you could
> sp

Looks like your comment got cut off.

The offset that lastOffsetInNode returns is actually *in* the node.  Or rather,
the position is.  Even if the editing code doesn't interpret it as being inside
the node.   [img, 1], that position is still "in" img, even though it's
invalid, so the editing code treats it as after the img.

Anyway, very interested in seeing the rest of your comment.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.