[Webkit-unassigned] [Bug 24487] [Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24487


jmalonzo at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zecke at selfish.org




------- Comment #3 from jmalonzo at gmail.com  2009-03-11 02:24 PDT -------
(In reply to comment #2)
> (From update of attachment 28433 [review])
> 
> > +    resetWebViewToConsistentStateBeforeTesting();
> > +
> 
> you might want to copy more there... e.g. the loading of about:blank (which we
> should kill at some point)

I'll do that in a different patch.

> 
> 
> ate after certain tests.
> >      webkit_web_view_open(webView, "about:blank");
> >  
> > -    gLayoutTestController->setJavaScriptProfilingEnabled(false);
> 
> NO! The g_object_set in resetWebView... is no good replacement!
> setJSProfilingEnabled will disable both Developer Extras and JS profiling. Is
> there a reason you want to keep Developer Extras enabled?

Why not? Why is the resetWebView... not a good replacement? developer extras is
also disabled in resetWebView...

Thanks


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.