[Webkit-unassigned] [Bug 24487] [Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 11 02:03:56 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=24487





------- Comment #2 from zecke at selfish.org  2009-03-11 02:03 PDT -------
(From update of attachment 28433)

> +    resetWebViewToConsistentStateBeforeTesting();
> +

you might want to copy more there... e.g. the loading of about:blank (which we
should kill at some point)


ate after certain tests.
>      webkit_web_view_open(webView, "about:blank");
>  
> -    gLayoutTestController->setJavaScriptProfilingEnabled(false);

NO! The g_object_set in resetWebView... is no good replacement!
setJSProfilingEnabled will disable both Developer Extras and JS profiling. Is
there a reason you want to keep Developer Extras enabled?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list