[Webkit-unassigned] [Bug 24493] [GTK] Misc patches for WebKitWebHistoryItem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24493





------- Comment #12 from xan.lopez at gmail.com  2009-03-11 02:23 PDT -------
(In reply to comment #11)
> (From update of attachment 28441 [review])
> 
> >  static void webkit_web_history_item_dispose(GObject* object)
> >  {
> >      WebKitWebHistoryItem* webHistoryItem = WEBKIT_WEB_HISTORY_ITEM(object);
> > -
> > -    GHashTable* table = webkit_history_items();
> > -
> > -    g_hash_table_remove(table, core(webHistoryItem));
> > -
> > -    /* destroy table if empty */
> > -    if (!g_hash_table_size(table))
> > -        g_hash_table_destroy(table);
> > +    static gboolean isDisposed = false;
> 
> this looks wrong. For every HistoryItem we will only dispose/clear the first
> time one instance of HistoryItem should get destroyed? What am I missing?
> 

Mmm, the point is to only remove ourselves from the global hash table, and
destroy it if it's empty, once, as dispose can run several times for the same
GObject.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.