[Webkit-unassigned] [Bug 24493] [GTK] Misc patches for WebKitWebHistoryItem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24493





------- Comment #11 from zecke at selfish.org  2009-03-11 02:19 PDT -------
(From update of attachment 28441)

>  static void webkit_web_history_item_dispose(GObject* object)
>  {
>      WebKitWebHistoryItem* webHistoryItem = WEBKIT_WEB_HISTORY_ITEM(object);
> -
> -    GHashTable* table = webkit_history_items();
> -
> -    g_hash_table_remove(table, core(webHistoryItem));
> -
> -    /* destroy table if empty */
> -    if (!g_hash_table_size(table))
> -        g_hash_table_destroy(table);
> +    static gboolean isDisposed = false;

this looks wrong. For every HistoryItem we will only dispose/clear the first
time one instance of HistoryItem should get destroyed? What am I missing?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.