[Webkit-unassigned] [Bug 24456] Chromium Unforking: Split ColorChromium.cpp into Windows + Mac variants

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24456


playmobil at google.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org




------- Comment #3 from playmobil at google.com  2009-03-09 01:46 PDT -------
Thanks for looking at this Eric,

This CL puts is into an intermediate state but I think the comments point
clearly at where we want to go.

While I'd like to land something finished with everything fully plumed through,
splitting the files up and adding comments creates an easier path to move in
that direction and allows us to unfork our copy of ColorMac.mm.

The motivation for taking the code from ColorMac is that, we do want to do our
own thing [in the face of MP & the Sandbox], and while duplicating code sucks,
IMHO the small quantity and comments are cleaner than other potential solutions
(upstreaming our ifdefed version of ColorMac.mm).

If you think there's a way we can comment things more clearly, or file bugs to
track this more closely I'm all for it.

Good point about the tint color changed notification on the Windows side, I'll
ping the relevant people and see what the right thing to do is.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.