[Webkit-unassigned] [Bug 24456] Chromium Unforking: Split ColorChromium.cpp into Windows + Mac variants

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 8 22:34:14 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=24456


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28408|review?                     |review-
               Flag|                            |




------- Comment #2 from eric at webkit.org  2009-03-08 22:34 PDT -------
(From update of attachment 28408)
Why is it so important to remove the dependance on ColorMac.mm?  It seems that
it would be better for us to not duplicate code as a general rule.

Splitting out the win version seems fine, but it seems it also needs a comment
about Windows listening to the browser process for focus changes.  Probably the
"getting the focus ring color from the browser process" could be x-platform
code.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list