[Webkit-unassigned] [Bug 22790] [Transforms] MediaPlayer::setRect() makes no sense with transforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22790





------- Comment #3 from eric.carlson at apple.com  2009-03-06 10:52 PDT -------
>> Index: WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp
>> ===================================================================
>>
>> -    //TODO: m_rect vs rect?
>> +    //TODO: m_size vs rect?
>
> Is the TODO still applicable?

I don't know if it is still applicable so I left the comment.

>> Index: WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h
>> ===================================================================
>>
>> +    IntRect m_rect;
>
>I have a minor preference for just storing a size in the member var,
>and constructing a (0,0,size) rect where you need one.

It make sense to store the Rect passed to  paint() when we are in a media
document so I think I will leave the member var as a rect


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.