[Webkit-unassigned] [Bug 22790] [Transforms] MediaPlayer::setRect() makes no sense with transforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22790


simon.fraser at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28366|review?                     |review+
               Flag|                            |




------- Comment #2 from simon.fraser at apple.com  2009-03-06 10:37 PDT -------
(From update of attachment 28366)
> Index: WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp
> ===================================================================

> -    //TODO: m_rect vs rect?
> +    //TODO: m_size vs rect?

Is the TODO still applicable?

> Index: WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h
> ===================================================================

> +    IntRect m_rect;

I have a minor preference for just storing a size in the member var,
and constructing a (0,0,size) rect where you need one.

> Index: WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm

> +    , m_rect(IntRect())

No need to initialize. IntRect has a ctor.

> +    	if (m_player->inMediaDocument() && r != m_rect) {
> +			// the QTMovieView needs to be placed in the proper location for document mode
> +        	m_rect = r;
> +			[view setFrame:m_rect];

Tabs here?

r=me with those comments addressed.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.