[Webkit-unassigned] [Bug 26703] bugzilla-tool apply-patches needs --local-commit and land-patches should support multiple bugs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26703





------- Comment #5 from eric at webkit.org  2009-06-24 23:38 PDT -------
(In reply to comment #3)
> (From update of attachment 31826 [review])
> Unfortunately, this has a "python license" which is meant to be permissable (I
> think) but doesn't meet our requirements and I'm fairly certain that
> http://diveintopython.org/dynamic_functions/stage1.html is the official source.

I emailed the author about using it under BSD license.  I've written a dumber
implementation myself for now.

> > +    @staticmethod
> > +    def apply_patches(patches, scm, commit_each):
> > +        for patch in patches:
> > +            scm.apply_patch(patch)
> > +            if commit_each:
> > +                scm.commit_locally_with_message(patch['name'])
> > +
> 
> This looks like it should be a scm method.  I also wish "name" was "message"
> since that how it seems to be used.

Perhaps.  Right now I'm going to leave it on that class.

> > +    @classmethod
> > +    def build_and_commit(cls, scm, options):
> > +        if options.build:
> > +            cls.build_webkit()
> > +            if options.test:
> > +                cls.run_webkit_tests()
> 
> Is it possible to set test w/o build?  Should this error out if that is done?

No, it's not possible.  It's also not possible to specifically enable testing. 
Testing defaults to on, you can disable it by either --no-build or --no-test. 
If someone only passes --no-build and not --no-test it doesn't make sense to
error.  Maybe some day we'll support explicit --no-build and --test, and then
we could have an error.

> > +    def execute(self, options, args, tool):
> > +        bugs_and_patches = []
> 
> This feels more like a dictionary to me.

Fixed.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.