[Webkit-unassigned] [Bug 26703] bugzilla-tool apply-patches needs --local-commit and land-patches should support multiple bugs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26703


levin at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31827|review?                     |review-
               Flag|                            |




------- Comment #4 from levin at chromium.org  2009-06-24 20:55 PDT -------
(From update of attachment 31827)
My real concern is the commit message so r- for that.


> diff --git a/WebKitTools/Scripts/bugzilla-tool b/WebKitTools/Scripts/bugzilla-tool
>          for patch in patches:
>              tool.scm().apply_patch(patch)
> +            if options.local_commit:
> +                tool.scm().commit_locally_with_message(patch['name'])

As discussed, the message given here doesn't seem like the right thing.


> diff --git a/WebKitTools/Scripts/modules/scm.py b/WebKitTools/Scripts/modules/scm.py
> index e226962..7c9593f 100644
> --- a/WebKitTools/Scripts/modules/scm.py
> +++ b/WebKitTools/Scripts/modules/scm.py
> @@ -65,14 +65,14 @@ class SCM:
>          output = process.communicate(input)[0].rstrip()
>          exit_code = process.wait()
>          if raise_on_failure and exit_code:
> -            raise ScriptError("Failed to run " + command)
> +            raise ScriptError("Failed to run \"%s\"  exit_code: %d  cwd: %s" % (command, exit_code, cwd))

Consider:
            raise ScriptError('Failed to run "%s"  exit_code: %d  cwd: %s' %
(command, exit_code, cwd))


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.